Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support marking utilities and theme values as deprecated #14915

Draft
wants to merge 8 commits into
base: feat/add-radius-utilities
Choose a base branch
from

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Nov 8, 2024

@thecrypticace
Copy link
Contributor Author

Thinking out loud here. It's possible we'll want the deprecation information to be more than just a boolean. Maybe a list of suggested classes? I'm hesitant to put "message" strings in here though. I'd prefer those kinds of things were generated by the IntelliSense extension.

@thecrypticace
Copy link
Contributor Author

thecrypticace commented Nov 8, 2024

So right now this is implemented in a very simple manner — affecting the classList metadata that IntelliSense uses. However, given that we have bare value support there are technically an infinite number of potential deprecated classes now or in the future this wouldn't be sufficient. I could also see a case in which a class becomes deprecated base of a specific modifier or something.

I think this means we may need something like a designSystem.classMetadata(string[]) API (an array because it would be better for IntelliSense to submit "Work" in bulk).

@thecrypticace thecrypticace changed the title Mark rounded-* utilities as deprecated in IntelliSense Support marking utilities and theme values as deprecated Nov 8, 2024
@philipp-spiess philipp-spiess force-pushed the feat/add-radius-utilities branch from 13f1106 to fed942b Compare November 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants