Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JS APIs available to plugins and configs in the Standalone CLI #15934

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Make JS APIs available to plugins and configs in the Standalone CLI #15934

wants to merge 6 commits into from
+145 −1

Conversation

thecrypticace
Copy link
Contributor

wip

@thecrypticace
Copy link
Contributor Author

This revealed a bug in Bun where build.module(…) exposes a Module record as the return value of require instead of using the default export. Gotta get that fixed before we can get this merged in.

@thecrypticace
Mark the virtual modules as ES Modules
4b285d6 
This will force the default export to be returned from `require()`
@thecrypticace
Update tests
a4c8837
@thecrypticace
Copy link
Contributor Author

This PR requires a fix in Bun before it can be merged: oven-sh/bun#16885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thecrypticace