Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not scan tailwind-merge sources for candidates #16005

Merged
merged 6 commits into from
Jan 29, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add intergation test
philipp-spiess committed Jan 29, 2025
commit 27ddcd77f4d703d0488a81013e64727db730185c
81 changes: 81 additions & 0 deletions integrations/vite/ignored-packages.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
import { candidate, css, fetchStyles, html, js, retryAssertion, test, ts, txt } from '../utils'

const WORKSPACE = {
fs: {
'package.json': txt`
{
"type": "module",
"dependencies": {
"tailwind-merge": "^2",
"@tailwindcss/vite": "workspace:^",
"tailwindcss": "workspace:^"
},
"devDependencies": {
"vite": "^6"
}
}
`,
'vite.config.ts': ts`
import tailwindcss from '@tailwindcss/vite'
import { defineConfig } from 'vite'
export default defineConfig({
build: { cssMinify: false },
plugins: [tailwindcss()],
})
`,
'index.html': html`
<head>
<link rel="stylesheet" href="./src/index.css" />
<script type="module" src="./src/index.js"></script>
</head>
`,
'src/index.js': js`
import { twMerge } from 'tailwind-merge'
twMerge('underline')
console.log('underline')
`,
'src/index.css': css`@import 'tailwindcss/utilities' layer(utilities);`,
},
}

test(
'does not scan tailwind-merge in production builds',
WORKSPACE,
async ({ fs, exec, expect }) => {
await exec('pnpm vite build')

let files = await fs.glob('dist/**/*.css')
expect(files).toHaveLength(1)
let [, content] = files[0]

expect(content).toMatchInlineSnapshot(`
"@layer utilities {
.underline {
text-decoration-line: underline;
}
}
"
`)
},
)

test('does not scan tailwind-merge in dev builds', WORKSPACE, async ({ spawn, expect }) => {
let process = await spawn('pnpm vite dev')
await process.onStdout((m) => m.includes('ready in'))

let url = ''
await process.onStdout((m) => {
let match = /Local:\s*(http.*)\//.exec(m)
if (match) url = match[1]
return Boolean(url)
})

await retryAssertion(async () => {
let styles = await fetchStyles(url, '/index.html')

expect(styles).not.toContain(candidate`flex`)
})
})