Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take NODE_PATH into account when resolving modules #16274

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Feb 5, 2025

Fixes #15847

This PR changes the node specific resolver config to takes the eventual NODE_PATH env into account.

Test plan

See #15847

Screenshot 2025-02-05 at 12 58 20

@philipp-spiess philipp-spiess requested a review from a team as a code owner February 5, 2025 12:00
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Can you add a changelog entry?

@philipp-spiess
Copy link
Member Author

Can you add a changelog entry?

Yes sir this is indeed part of my set of abilities.

@philipp-spiess philipp-spiess merged commit 3f8e764 into main Feb 5, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/node-path-env branch February 5, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V4] new import style doesn't work for node_modules in non-standard location (e.g. gradle)
2 participants