Adjustment for compose preview config #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
Merged
Merged
This was referenced Dec 4, 2024
takahirom
changed the base branch from
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
to
main
| } | ||
|
|
||
| @ExperimentalRoborazziApi | ||
| fun RoborazziComposeConfigBuilder.configurationUiMode(configurationUiMode: Int): RoborazziComposeConfigBuilder { |
There was a problem hiding this comment.
I'd call this just UiMode but your call.
previewDevice sounds good to me
takahirom
force-pushed
the
12-04-adjustment_for_compose_preview_config
branch
from
b0b792a to
0810ceb
Compare
takahirom
changed the base branch from
main
to
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
takahirom
changed the base branch from
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
to
main
takahirom
force-pushed
the
12-04-adjustment_for_compose_preview_config
branch
from
0810ceb to
832b956
Compare
takahirom
changed the base branch from
main
to
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
takahirom
changed the base branch from
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
to
main
|
@sergio-sastre Thanks as always. I think I'm ready to release this. Do you have any concerns? |
Codewise looks good to me. 😊 |
takahirom
changed the base branch from
main
to
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
takahirom
force-pushed
the
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
branch
from
593f2a4 to
f94c43a
Compare
takahirom
force-pushed
the
12-04-adjustment_for_compose_preview_config
branch
from
832b956 to
fa353e7
Compare
takahirom
changed the base branch from
12-03-add_a_deprecated_method_of_composablepreview_androidpreviewinfo_.applytorobolectricconfiguration_as_it_was_a_experimentalapi
to
graphite-base/586
takahirom
force-pushed
the
12-04-adjustment_for_compose_preview_config
branch
from
fa353e7 to
f8c3b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.