Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting of left column in reports #644

Merged

Conversation

mannodermaus
Copy link
Contributor

@mannodermaus mannodermaus commented Feb 3, 2025

This is a proposal to adjust the layout of Roborazzi reports a little, addressing some quirks I have found when working with it. Left is before, right is after!

General updates

I adjusted the default width of the report container to account for larger screens. Instead of materialize's default values (90%, max 1280px), it is now 95% with a maximum width of 1440px. Furthermore, the ratio between the left and right columns is now 40-60, a little different to the 30-70 from before. I also added a little fix for contextData: Before this PR, if any contextData has an empty value, then no context data would be shown at all. This is now changed so that only these empty context data entries are filtered out instead.

Show relative path to output directory above each file name

This accounts for use cases where a non-default directory is used to store images. The folder is a little smaller than the file name, too.

Screenshot 2025-02-03 at 16 40 08

Fix display of contextData and make it easier to digest

First of all, fix the missing line break. Furthermore, use a little sub-table to display context data key-value pairs more neatly. Add a cute badge thingy to make this data stand out a bit more.

Screenshot 2025-02-03 at 16 40 35

Fix display of aiAssertionResults

Another missing line break fix. Use a badge to separate these results from the main file name. Add some tweaks to color and size to achieve hierarchy of information.

Screenshot 2025-02-03 at 16 42 05 Screenshot 2025-02-03 at 16 38 10

Copy link
Owner

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! It looks excellent.

@takahirom takahirom merged commit 54df6af into takahirom:main Feb 5, 2025
7 checks passed
@mannodermaus mannodermaus deleted the feature/improved-report-format branch February 6, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants