Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate limit err #261

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

fix: rate limit err #261

wants to merge 2 commits into from

Conversation

takanome-dev
Copy link
Owner

@takanome-dev takanome-dev commented Dec 3, 2024

What type of PR is this? (check all applicable)

  • πŸ’‘ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • ⏩ Revert

Description

This pr fixes the issues where users hit the second rate limit

Related Tickets & Documents

fixes #251

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@takanome-dev takanome-dev mentioned this pull request Dec 3, 2024
2 tasks
@koppor
Copy link
Contributor

koppor commented Dec 4, 2024

Does this make use of https://github.com/octokit/plugin-throttling.js/#readme? This is the official GitHub recommended way!

Source: https://github.com/octokit/octokit.js?tab=readme-ov-file#request-error-handling

@takanome-dev
Copy link
Owner Author

Does this make use of https://github.com/octokit/plugin-throttling.js/#readme? This is the official GitHub recommended way!

Cool, I didn't know that. Will have to rewrite some part of the action. Thanks

@takanome-dev takanome-dev marked this pull request as ready for review December 11, 2024 05:58
@takanome-dev
Copy link
Owner Author

@koppor would you like to give this a shot?

In the meantime, I will try resolving other issues in this pr before merging

@koppor
Copy link
Contributor

koppor commented Dec 13, 2024

The output is

βš™ Processing 0 issues:

(Link to action output: https://github.com/JabRef/jabref/actions/runs/12296140810/job/34314530086)

But I have 23 issues with the label "Assigned": https://github.com/JabRef/jabref/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3A%22%F0%9F%93%8D%20Assigned%22

I think, the number should be "23", shouldn't it?


Update: I checked the code and it appears that πŸ“ Assigned is found at action.yml. Thus, it should maybe work. However, the 0 still puzzles me.

@koppor
Copy link
Contributor

koppor commented Dec 13, 2024

Did not work 😒

https://github.com/JabRef/jabref/actions/runs/12315417134

You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 2402:3CBDD4:2C54AC9:57ADDC6:675C24AE. - https://docs.github.com/free-pro-team@latest/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits

@takanome-dev
Copy link
Owner Author

Sorry for the delay, looking into it

@koppor
Copy link
Contributor

koppor commented Jan 13, 2025

@takanome-dev May I ask if you could find some time to work on it? GSoC is coming up and this action really helps to manage the workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Retry on rate limit
2 participants