Skip to content

Commit

Permalink
Merge pull request #51 from takutakahashi/update_processing
Browse files Browse the repository at this point in the history
processing bool is missed
  • Loading branch information
takutakahashi authored Oct 15, 2020
2 parents af9c529 + 97a9c1d commit 1a2213a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.envrc
*.tfvars
**/.terraform
.ignore
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

# Image URL to use all building/pushing image targets
IMG ?= takutakahashi/loadbalancer-controller:v0.3.1
IMG ?= takutakahashi/loadbalancer-controller:v0.3.3
# Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
CRD_OPTIONS ?= "crd:trivialVersions=true"

Expand Down Expand Up @@ -55,7 +55,7 @@ generate: controller-gen
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

# Build the docker image
docker-build: test
docker-build:
docker build . -t ${IMG}

# Push the docker image
Expand Down
2 changes: 1 addition & 1 deletion config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ kind: Kustomization
images:
- name: controller
newName: takutakahashi/loadbalancer-controller
newTag: v0.3.1
newTag: dev-1015115903
3 changes: 0 additions & 3 deletions pkg/terraform/terraform.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,6 @@ func (t TerraformClient) isProcessing() (bool, error) {
if !strings.Contains(job.Name, t.awsBackend.Name) {
continue
}
if !strings.Contains(job.Name, t.awsBackend.ResourceVersion) {
return true, nil
}
if job.Status.CompletionTime != nil {
return false, nil
}
Expand Down

0 comments on commit 1a2213a

Please sign in to comment.