fix(colorPicker): Fix init logic in [email protected] and lower

talamaska · Apr 21, 2017 · 8927deb · 8927deb
1 parent 9dbb2c7
commit 8927deb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/color-picker.bundle.js b/src/color-picker.bundle.js
@@ -156,11 +156,16 @@
             knob.addEventListener('transitionend', _onKnobTransitionEnd);
             ripple.addEventListener('animationend', _onRippleAnimationEnd);
             palette.addEventListener('transitionend', _onPaletteTransitionEnd);
+
+            // @fix angular < 1.5.4 doesn't trigger $onChanges properly on init
+            $onChanges.call(this);
         }
 
         function $onChanges() {
             if (this.color && 'red' in this.color && 'green' in this.color && 'blue' in this.color) {
                 this.angle = ColorPickerService.rgbToHsl(this.color.red, this.color.green, this.color.blue).hue;
+            } else {
+                this.angle = 0;
             }
         }
 

diff --git a/src/color-picker.component.js b/src/color-picker.component.js
@@ -156,11 +156,16 @@
             knob.addEventListener('transitionend', _onKnobTransitionEnd);
             ripple.addEventListener('animationend', _onRippleAnimationEnd);
             palette.addEventListener('transitionend', _onPaletteTransitionEnd);
+
+            // @fix angular < 1.5.4 doesn't trigger $onChanges properly on init
+            $onChanges.call(this);
         }
 
         function $onChanges() {
             if (this.color && 'red' in this.color && 'green' in this.color && 'blue' in this.color) {
                 this.angle = ColorPickerService.rgbToHsl(this.color.red, this.color.green, this.color.blue).hue;
+            } else {
+                this.angle = 0;
             }
         }