Allow external account type #723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjgbeelen
requested review from
leanaha and
santiagofdialpad
and removed request for
a team
leanaha
approved these changes
May 24, 2024
TheKevJames
requested changes
May 30, 2024
There was a problem hiding this comment.
Appreciate the contribution, but unfortunately this won't be enough -- we actually need to build the code which knows how to authenticate as an external account. See, for example, the Token.refresh() method, which would need to be updated to include a new workflow for refreshing said new type of token.
It sounds like (from reading #722) you've got a test case set up? You should be able to install gcloud-aio-auth from this branch for testing. Alternatively, if you could point us in the direction of that test case, it would be great if we could add that approach to our integration tests directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix #722 , but not sure if it is enough