-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CameraGroup class #146
Conversation
and provide default triangulate_dlt_vectorized function
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 96.20% 96.39% +0.19%
==========================================
Files 18 18
Lines 2505 2583 +78
==========================================
+ Hits 2410 2490 +80
+ Misses 95 93 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very clean :)
- Likely should also filter out points when only a single points is non-nan, but curious...
and use fixture
loops over Camera.project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions, mostly minor
Regarding CI failing: see this commit --> 1637f70 Edit: now in |
now that standalone triangulation method is implemented
* add support for ndx-pose > 0.2.0 * black * fix double device and black * fix pydocstyle * CI fixes --------- Co-authored-by: Talmo Pereira <[email protected]>
Co-authored-by: Talmo Pereira <[email protected]>
Co-authored-by: Talmo Pereira <[email protected]>
and update docstrings
84921ad
to
756f340
Compare
I totally deranged the git history when I rebased... but, after fixing the merge conflicts, the diff is correct. |
This PR is stacked on #145 which implements and tests the
Camera
class. In this PR, we add theCameraGroup
class.