-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running inference on Bottom-up models with CUDA #133
Conversation
WalkthroughThe diff updates tensor initialization in Changes
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 96.64% 97.21% +0.56%
==========================================
Files 23 40 +17
Lines 1818 4128 +2310
==========================================
+ Hits 1757 4013 +2256
- Misses 61 115 +54 ☔ View full report in Codecov by Sentry. |
6a7d28a
to
f36b6d6
Compare
This PR fixes a bug that occurs while running inference on bottom-up models with CUDA. The error was associated with using legacy tensor constructor (
torch.Tensor
), which doesn't support assigning device on construction.Summary by CodeRabbit
compute_dists
to enhance code clarity without impacting functionality.