WIP : improvements for by_symbol_match #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxanebellot
changed the title
|
It seems I was a little too enthousiastic. This is a WIP |
|
Can't repoen because of force-push ! To be continued here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
This may be out of nowhere, but playing around with your lib, and found the "heuristic" in
by_symbol_matchcould be significantly improved by using a regex to avoid finding currency symbols in words.This both improves the detection of the right currency and reduces the detection of bad currencies !
For reference, I also added a little case-insensitivness test case :)