fix: limits in differential expression plots

tanaylab · Dec 20, 2023 · b0084a2 · b0084a2
1 parent 9b3f30d
commit b0084a2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: MCView
 Title: A Shiny App for Metacell Analysis
-Version: 0.2.22
+Version: 0.2.23
 Authors@R: 
     person(given = "Aviezer",
            family = "Lifshitz",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# MCView 0.2.23
+
+* Fix: plot limits were sometimes too low in differential expression plots.
+
 # MCView 0.2.22
 
 * Added an option to sort gene heatmaps by metadata within each cell type. 

diff --git a/R/plot_mc_mc_gene.R b/R/plot_mc_mc_gene.R
@@ -8,9 +8,9 @@
 plot_mc_mc_gene <- function(df, metacell1, metacell2, highlight = NULL, label_prefix = "MC #", x_label_suffix = "") {
     xylims <- expr_breaks
 
-    xmax <- min(c(1:length(xylims))[xylims >= max(df[, metacell1])] - 1e-10)
+    xmax <- min(c(1:length(xylims))[xylims >= max(df[, metacell1]) - 1e-10])
     xmin <- max(c(1:length(xylims))[xylims <= min(df[, metacell1]) + 1e-10])
-    ymax <- min(c(1:length(xylims))[xylims >= max(df[, metacell2])] - 1e-10)
+    ymax <- min(c(1:length(xylims))[xylims >= max(df[, metacell2]) - 1e-10])
     ymin <- max(c(1:length(xylims))[xylims <= min(df[, metacell2]) + 1e-10])
 
     if (!is.null(highlight)) {