Docs@attributes and values should be in ascii encoding (#59)

* docs: attributes and values should be in ASCII encoding see #58 * removed accidently added file
tanaylab · Jan 5, 2022 · fbe7065 · fbe7065
1 parent c36ddf8
commit fbe7065
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/R/track.R b/R/track.R
@@ -317,6 +317,8 @@ emr_track.attr.rm <- function(track = NULL, attr = NULL) {
 #' This function creates a track attribute and assigns 'value' to it. If the
 #' attribute already exists its value is overwritten.
 #'
+#' Note that both attributes and values sould be in ASCII encoding.
+#'
 #' @param track track name
 #' @param attr attribute name
 #' @param value value

diff --git a/man/emr_track.attr.set.Rd b/man/emr_track.attr.set.Rd
diff --git a/src/EMRTrack.cpp b/src/EMRTrack.cpp
@@ -193,10 +193,10 @@ EMRTrack::TrackAttrs EMRTrack::load_attrs(const char *, const char *filename)
 		} else {
 			if (idx) {
 				if (name.empty() || val.empty())
-					TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s", filename); 
+					TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s (1)", filename); 
 
 				if (attrs.find(name) != attrs.end()) // duplicated attributes
-					TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s", filename); 
+					TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s (2)", filename); 
 
 				attrs[name] = val;
 				name.clear();
@@ -210,7 +210,7 @@ EMRTrack::TrackAttrs EMRTrack::load_attrs(const char *, const char *filename)
 		TGLError<EMRTrack>(FILE_ERROR, "Failed to read attributes file %s: %s", filename, strerror(errno));
 
 	if (idx) 
-		TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s", filename); 
+		TGLError<EMRTrack>(BAD_FORMAT, "Invalid format of attributes file %s (3)", filename); 
     return attrs;
 }