Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 encoding in track attributes #58

Open
aviezerl opened this issue Dec 23, 2021 · 0 comments
Open

UTF-8 encoding in track attributes #58

aviezerl opened this issue Dec 23, 2021 · 0 comments
Labels
bug Something isn't working minor

Comments

@aviezerl
Copy link
Collaborator

Currently, when setting attribute value to a non-ASCII convertible string (e.g., in Hebrew), the next call for emr_track.attr.get/set would fail with an error of "Invalid format of attributes file."

The problem is caused by the use of getc of BufferedFile.h, which doesn't deal with the variable length of UTF-8 encoded strings.

Example:

library(naryn)
load_test_db()
emr_track.attr.set("ph1", "test", "סבתא")
emr_track.attr.export()
@aviezerl aviezerl added bug Something isn't working minor labels Dec 23, 2021
aviezerl added a commit that referenced this issue Dec 23, 2021
* docs: attributes and values should be in ASCII encoding
see #58

* removed accidently added file
aviezerl added a commit that referenced this issue Jan 5, 2022
* docs: attributes and values should be in ASCII encoding
see #58

* removed accidently added file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant