Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fontsUrlHash to options to avoid adding extra hash parameters to url function #232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nasserghiasi
Copy link

@nasserghiasi nasserghiasi commented Jun 25, 2021

This is very useful when a developer wants to build icons through the webpack build process or git hooks and commit the output.
But in the current state of the repository developers, cant prevent adding hash parameters to the output CSS or SCSS file and on each running of build those parameters will change and developers should be careful about that changes and revert them. So this is annoying.

Before:
@font-face { font-family: $icons-font; src: url('./icon-font.woff2?6b5eab133ec268cf9627ede6bfc39908') format('woff2'), url('./icon-font.woff?6b5eab133ec268cf9627ede6bfc39908') format('woff'); }

After:
@font-face { font-family: $icons-font; src: url('./icon-font.woff2?') format('woff2'), url('./icon-font.woff?') format('woff'); }

@nasserghiasi nasserghiasi changed the title feat: add fontsUrlHash to prevent adding extra hash parameters to url function add fontsUrlHash to options to avoid adding extra hash parameters to url function Jun 25, 2021
@nasserghiasi nasserghiasi marked this pull request as ready for review June 25, 2021 13:37
@vaceslav
Copy link

vaceslav commented Jul 2, 2021

Any Progress on this PR? It is exactly my problem now. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants