-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ligatures): adds a proposal to add ligatures #315
base: master
Are you sure you want to change the base?
Conversation
@oscargm I think its probably better to revert the changes on the package-lock file? As they seem not necessary for this change (probably its only a npm version difference) it would help the @tancredi review. @tancredi You think this is a good change? If you need more context, this would allow the font to be used with the Json generated with fantasticon {
"bank-fill": 61697,
"bank": 61698,
"building-fill": 61699,
"building": 61700,
"community-fill": 61701,
"community": 61702,
"government-fill": 61703,
"government": 61704
} .my-icon {
font-family: icons; // font family generated with fantasticon
font-weight: normal;
font-style: normal;
font-size: 24px;
display: inline-block;
line-height: 1;
text-transform: none;
letter-spacing: normal;
word-wrap: normal;
white-space: nowrap;
direction: ltr;
-webkit-font-smoothing: antialiased;
text-rendering: optimizeLegibility;
-moz-osx-font-smoothing: grayscale;
font-feature-settings: 'liga';
} <span class="my-icon">building</span> The html would render the icon without using the before or after pseudo elements. |
Yeah sure @vfreitas- no problem. I was awaiting for @tancredi's feedback, if he agrees with the proposal I can try to continue and make a proposal for extending the configuration and fix the tests. |
waiting for this PR too!!!!!! |
Fixing snapshot testing here |
Also added a field named |
@tancredi could we review the PR and merge it in case it's okay? |
Waiting for this too. |
Related with #182