-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tangle-dapp): UI Updates & Add Rewards Claiming Functionality #2754
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tangle-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The reward-claiming test in the video failed because there are no active services to increase the rewards, resulting in no rewards to claim. In the demo, I enabled the claiming function in the code to demonstrate interaction with the chains (Substrate & EVM). In reality, we have a check to render the claiming button. |
@AtelyPham I thought we don't need active services to claim the reward, users should be eligible for TNT rewards with just making a deposit in restaking. also can we update the UI as the following so it is clear to the user the amount of unclaimed rewards? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move the send action button next to the TNT amount (shown in image above), as for viewing the rewards currently that is for nomination. so I think user can just go to nomination page to claim rewards. we don't have to collide it with claiming restaking rewards.
@1xstj can you set up the rewards for testnet restake vaults so we can get this PR through? we want to be able to claim rewards with deposit APY on testnet vaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems our reward processing is not where we need it to be right now. We can't leave todos like this for later. These features need to ship 100% complete. No more breaking features like this down it's bad practice for this type of thing and is slowing us down.
…ng delegate button
Status update? There are now EVM assets and you and yuri should have ability to create them to test out rewards, points, and more. |
After my meeting with Mona yesterday, there were some UI updates, and new APIs were added to retrieve the details of ERC20 assets. It will be ready for review by the end of today. |
Changes since the last review:
|
Summary of changes
Provide a detailed description of proposed changes.
types
directory.Proposed area of change
Put an
x
in the boxes that apply.apps/tangle-dapp
apps/tangle-cloud
libs/tangle-shared-ui
libs/webb-ui-components
Associated issue(s)
Specify any issues that can be closed from these changes (e.g.
Closes #233
).Screen Recording
If possible provide screenshots and/or a screen recording of proposed change.
Substrate
CleanShot.2025-01-23.at.12.22.36.mp4
EVM
CleanShot.2025-01-23.at.13.03.10.mp4