update #11
Merged
update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to doc of rodio, the attached OutputStreamHandles will no longer work after OutputStream is dropped. So player need to own OutputStream. And currently there is no way to unstopped a Sink, so we has no choice but to alloc a new Sink in player->start().
Crash is caused by the file passed to mp3_duration is a error response instread of mp3 file because the HOST field in request header does not match the url.
Fix two bugs: no sound and crash on some songs
Fix regex to handle repeating patterns in lyric & Add translated lyric support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.