Skip to content

Commit

Permalink
feat: Add priority based memory reclaim framework
Browse files Browse the repository at this point in the history
Summary:
* Adds priority base reclaiming to memory reclaim framework. The priority determines which memory pool to reclaim first on the same level. This would help to make reclaim more application logic aware. 
* Make join node reclaim priority lower than others. This is because cost of reclaiming (spilling) on join node is high compared to other nodes.

X-link: facebookincubator/velox#11598

Reviewed By: xiaoxmeng

Differential Revision: D66261340

Pulled By: tanjialiang
  • Loading branch information
tanjialiang authored and facebook-github-bot committed Dec 6, 2024
1 parent 63b3d81 commit 5ec7d7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dwio/nimble/velox/tests/VeloxWriterTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ TEST_P(RawStripeSizeFlushPolicyTest, RawStripeSizeFlushPolicy) {
namespace {
class MockReclaimer : public velox::memory::MemoryReclaimer {
public:
explicit MockReclaimer() {}
explicit MockReclaimer() : velox::memory::MemoryReclaimer(0) {}
void setEnterArbitrationFunc(std::function<void()>&& func) {
enterArbitrationFunc_ = func;
}
Expand Down

0 comments on commit 5ec7d7f

Please sign in to comment.