[WIP] 🚧 v3 #20
[WIP] 🚧 v3 #20
Conversation
| @@ -1,2 +1 @@ | |||
| defaults | |||
| ie 11 | |||
There was a problem hiding this comment.
📝 Dropping IE support.
| @@ -7,6 +7,9 @@ | |||
| "browser": true, | |||
| "es6": true | |||
| }, | |||
| "parserOptions": { | |||
| "ecmaVersion": 2020 | |||
There was a problem hiding this comment.
📝 Upgrading to ES2020.
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "baseUrl": "http://localhost:8080", | |||
| "firefoxGcInterval": null, | |||
There was a problem hiding this comment.
📝 Removing deprecated Cypress options.
| // eslint-disable-next-line cypress/no-unnecessary-waiting | ||
| cy.getSlider('test').scrollTo('right') | ||
| .wait(0) | ||
| .wait(350) |
There was a problem hiding this comment.
📝 Intersection Observer change callbacks are debounced by 300ms, so need to wait at least that long for events to fire.
| cy.getSlider('test').children(':nth-child(3)').scrollIntoView(); | ||
| // NOTE: Add `duration` so Intersection Observer fires. | ||
| // @see https://github.com/cypress-io/cypress/issues/3848#issuecomment-478132607 | ||
| cy.getSlider('test').children(':nth-child(3)').scrollIntoView({ duration: 100 }); |
There was a problem hiding this comment.
❓ Is this duration still necessary? Or can we simply scroll and still get the same result?
|
|
||
| <!-- ⚙️ Scripts --> | ||
| <script src="./snap-slider.min.js"></script> | ||
| <script src="https://unpkg.com/[email protected]/dist/smoothscroll.min.js"></script> |
There was a problem hiding this comment.
📝 Separating smooth scroll polyfill.
| "element-closest": "^3.0.2", | ||
| "lodash": "^4.17.19", | ||
| "smoothscroll-polyfill": "^0.4.4", | ||
| "tabbable": "^4.0.0" |
There was a problem hiding this comment.
📝 Removing all dependencies (except lodash's debounce function).
| "stylelint": "^13.6.1", | ||
| "stylelint-config-property-sort-order-smacss": "^6.3.0", | ||
| "stylelint-config-standard": "^20.0.0", | ||
| "@babel/core": "^7.15.8", |
There was a problem hiding this comment.
📝 Upgrading all npm packages (should also close open dependabot PRs).
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| module.exports = { | |||
| plugins: [ | |||
| require('autoprefixer')({ grid: 'autoplace' }), | |||
| require('autoprefixer')(), | |||
There was a problem hiding this comment.
📝 Removing legacy CSS Grid support for IE.
| @@ -50,7 +49,7 @@ const common = { | |||
| // Bundle Analyzer | |||
| const analyzer = new BundleAnalyzerPlugin({ | |||
| analyzerMode: 'static', | |||
| openAnalyzer: process.env.TEST !== 'true', | |||
| openAnalyzer: false, // process.env.TEST !== 'true', | |||
There was a problem hiding this comment.
📝 Temporarily disabling bundle analyzer.
Need to turn back on before launch!
|
Hi, first of all thanks for your awesome work @tannerhodges , is there any update about this? |
📦 Latest Release
v3.0.0-alpha.2
🚧 Todo