Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content length in proxy.js when response from server sends it as a string #30

Closed
wants to merge 1 commit into from

Conversation

jesseditson
Copy link

Like the title says - this one line fix will make proxying to servers that don't send an int as content-length work.

@ljharb

This comment has been minimized.

@jesseditson

This comment has been minimized.

@ljharb
Copy link
Collaborator

ljharb commented Jan 11, 2020

hmm - it looks like lib/proxy doesn't exist anymore, and there's nothing currently setting content-length - the closest i could find was https://github.com/substack/testling/blob/master/bin/cmd.js#L159.

I know it's been a very long time, but do you know if the same issue is still happening?

@jesseditson
Copy link
Author

Reading #27 it looks like the issue was that trying to use testling example/localhost.js --browser=chrome was failing - however it's been far too long for me to shed any more light than what's in the issue.

Happy to close this one out in the meantime, thanks for taking the reins on this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants