-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable luatest logging #429
Merged
ylobankov
merged 2 commits into
tarantool:master
from
ochaplashkin:bump-luatest-to-add-more-logs
Jun 11, 2024
Merged
Enable luatest logging #429
ylobankov
merged 2 commits into
tarantool:master
from
ochaplashkin:bump-luatest-to-add-more-logs
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb7b84d
to
6ba1e3a
Compare
ylobankov
reviewed
May 27, 2024
0a477cf
to
e85db54
Compare
1.0.1-6-gd985997
Statistics:
* pass: 1881
* disabled: 73
* skip: 8
* fail: 5
Failed tasks:
- [box-luatest/gh_9797_netbox_on_disconnect_error_hangs_server_test.lua, null]
# logfile: /tmp/t/log/067_box-luatest.log
# reproduce file: /tmp/t/reproduce/067_box-luatest.list.yaml
# luatest logfile: /tmp/t/067_box-luatest/run.log
- [box-luatest/gh_9309_errors_in_triggers_test.lua, null]
# logfile: /tmp/t/log/058_box-luatest.log
# reproduce file: /tmp/t/reproduce/058_box-luatest.list.yaml
# luatest logfile: /tmp/t/058_box-luatest/run.log
- [box-luatest/gh_9994_next_prefix_iterator_test.lua, null]
# logfile: /tmp/t/log/067_box-luatest.log
# reproduce file: /tmp/t/reproduce/067_box-luatest.list.yaml
# luatest logfile: /tmp/t/067_box-luatest/run.log
- [box-luatest/varbinary_test.lua, null]
# logfile: /tmp/t/log/061_box-luatest.log
# reproduce file: /tmp/t/reproduce/061_box-luatest.list.yaml
# luatest logfile: /tmp/t/061_box-luatest/run.log
- [box-luatest/gh_7904_export_box_schema_version_to_public_api_test.lua, null]
# logfile: /tmp/t/log/061_box-luatest.log
# reproduce file: /tmp/t/reproduce/061_box-luatest.list.yaml
# luatest logfile: /tmp/t/061_box-luatest/run.log Patch: diff --git a/.gitmodules b/.gitmodules
index 229062bea..716b602c8 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -17,7 +17,7 @@
ignore = dirty
[submodule "test-run"]
path = test-run
- url = https://github.com/tarantool/test-run.git
+ url = https://github.com/ochaplashkin/test-run.git
ignore = dirty
[submodule "src/lib/small"]
path = src/lib/small
diff --git a/test-run b/test-run
index dd0006329..e85db54ee 160000
--- a/test-run
+++ b/test-run
@@ -1 +1 @@
-Subproject commit dd0006329d3c9ca30a956b66e8b61db1a57e51b9
+Subproject commit e85db54eec64bcbd066416f7e1c7a680e31fb6c1
diff --git a/test/box-luatest/gh_7904_export_box_schema_version_to_public_api_test.lua b/test/box-luatest/gh_7904_export_box_schema_version_to_public_api_test.lua
index 18af7968f..9953e2b28 100644
--- a/test/box-luatest/gh_7904_export_box_schema_version_to_public_api_test.lua
+++ b/test/box-luatest/gh_7904_export_box_schema_version_to_public_api_test.lua
@@ -23,7 +23,7 @@ g.test_box_internal_schema_version_deprecation = function(cg)
local deprecation_warning =
'box.internal.schema_version will be removed, please use box.info.schema_version instead'
t.assert_is_not(cg.server:grep_log(deprecation_warning, 256), nil)
- local log_file = g.server:exec(function() return box.cfg.log end)
+ local log_file = g.server:exec(function() return rawget(_G, 'box_cfg_log_file') or box.cfg.log end)
fio.truncate(log_file)
cg.server:exec(function()
box.internal.schema_version()
diff --git a/test/box-luatest/gh_9309_errors_in_triggers_test.lua b/test/box-luatest/gh_9309_errors_in_triggers_test.lua
index 5c142adbf..d636f3708 100644
--- a/test/box-luatest/gh_9309_errors_in_triggers_test.lua
+++ b/test/box-luatest/gh_9309_errors_in_triggers_test.lua
@@ -95,7 +95,9 @@ g.test_ctl_triggers_error = function()
box.ctl.on_shutdown(function() error("on_shutdown error") end, nil)
end)
- local server_log_path = g.server:exec(function() return box.cfg.log end)
+ local server_log_path = g.server:exec(function()
+ return rawget(_G, 'box_cfg_log_file') or box.cfg.log
+ end)
g.server:drop()
t.assert(g.server:grep_log("on_shutdown error", nil,
{filename = server_log_path}))
diff --git a/test/box-luatest/gh_9797_netbox_on_disconnect_error_hangs_server_test.lua b/test/box-luatest/gh_9797_netbox_on_disconnect_error_hangs_server_test.lua
index bff0cbc37..727c7dbbd 100644
--- a/test/box-luatest/gh_9797_netbox_on_disconnect_error_hangs_server_test.lua
+++ b/test/box-luatest/gh_9797_netbox_on_disconnect_error_hangs_server_test.lua
@@ -24,7 +24,7 @@ g.test_on_disconnect_error_hangs_server = function(cg)
local log_file = cg.server:exec(function()
box.ctl.set_on_shutdown_timeout(1)
-- `grep_log` will not be able to retrieve it after we drop the server.
- return box.cfg.log
+ return rawget(_G, 'box_cfg_log_file') or box.cfg.log
end)
cg.server:drop()
t.assert_not(cg.server:grep_log('on_shutdown triggers failed', 1024, Failed tests: TAP13 parse failed ('utf-8' codec can't decode byte 0xbe in position 4198: invalid start byte) |
ylobankov
reviewed
Jun 10, 2024
1e3fb83
to
a26c9dc
Compare
Done Statistics:
* pass: 1886 (flaky: 1)
* disabled: 73
* skip: 8 |
ylobankov
reviewed
Jun 11, 2024
a26c9dc
to
e7310f1
Compare
The log file may contain non-utf8 characters which will cause an error: TAP13 parse failed ('utf-8' codec can't decode byte 0xbe ... Replace non-utf8 characters when reading a file. Part of tarantool#427
e7310f1
to
81ee5d3
Compare
If the test fails and there is a luatest log file (`run.log` by default) you'll see the following output: - [box-luatest/varbinary_test.lua, null] # logfile: /tmp/t/log/031_box-luatest.log # luatest logfile: /tmp/t/031_box-luatest/run.log # reproduce file: /tmp/t/reproduce/031_box-luatest.list.yaml Closes tarantool#427
81ee5d3
to
9727b6c
Compare
ylobankov
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tap13: fix parsing non-utf8 chars
The log file may contain non-utf8 characters which will cause an error:
Replace non-utf8 characters when reading a file.
Part of #427
Enable logging to unified file
If the test fails and there is a unified log file(
run.log
by default) you'll see the following output:Closes #427