Skip to content

dev meeting 20200930

Jump to bottom
Guillaume Petiot edited this page Sep 30, 2020 · 1 revision

Present at the meeting:

  • Sonja Heinze (@pitag-ha)
  • Guillaume Petiot (@gpetiot)

Current plan

  • Sonja looks into the linting phase, list the various checks and classify them either as mandatory (always run when building the tarball) or lint (run as a separate step that can be disabled).
  • Guillaume finishes the draft workflow
  • Nathan gets the remaining PRs merged
  • Nathan work on git submodules support

Meeting notes

Sonja hasn't had time to work on dune-release these past few weeks, but will have a look at Nathan's review on the pull request deprecating the delegates.

Guillaume rebased and improved a bit PR#219. Further improvements can be done once the delegates are removed so we can focus on the github implementation.

A few pull requests are pending and waiting to be reviewed. A waiting for review tag has been added on the the PR dashboard to make their status explicit. We hope to review and merge these pull requests before cutting a minor release 1.5.0, since quite a number of things have already been fixed since 1.4.0 but we didn't yet tackle the breaking changes of 2.0.0.

Some pull requests and issues have been opened to suggestion improvements to the linting phase, but we need to plan out this change before merging these pull requests. We will open a new issue to discuss about what the new linting command will do, what will be considered a fatal error or a warning, and for which command(s) of dune-release it may cause an issue. We need to know whether a check is passed for all the dune-release commands, and whether all checks are passed for some dune-release command. It is useful to detail for which set of comands a specific check might be problematic when failing, as some users might only use a subset of dune-release commands. We can further discuss the way to represent the reporting of the linting command to the user in the issue, so far we discussed having a matrix view:

[OK] aaa                  [distrib:OK][publish:OK][opam pkg:OK][opam submit:OK]
[WARN] bbb                [distrib:OK][publish:OK][opam pkg:KO][opam submit:KO]
[KO] ccc                  [distrib:KO][publish:KO][opam pkg:KO][opam submit:KO]

or a linear view:

[OK] aaa                 
[WARN] bbb            
NOTE: bbb is necessary for `dune-release submit`
[KO] ccc
NOTE: ccc is necessary for `opam submit`
Clone this wiki locally