feature: kitchen sink app #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajajawahar
requested review from
Younes-Charfaoui,
NandagopalR,
askNilesh and
Meg979
Younes-Charfaoui
approved these changes
Mar 2, 2024
androidmahi
approved these changes
Mar 4, 2024
…ndroid into younes/kitchenSink
askNilesh
requested changes
Mar 4, 2024
Comment on lines
+22
to
+23
| Text(text = "TUIAppTopBar", style = TUITheme.typography.heading3) | ||
| TUIAppTopBar( |
There was a problem hiding this comment.
@rajajawahar shall we add some vertical space between this two components
Comment on lines
+38
to
+58
| TUIAttachmentUpload( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(8.dp), | ||
| type = TUIMediaThumbnailType.Image(someImage), | ||
| attachmentName = "document.jpg", | ||
| onAttachmentClick = { | ||
| // Handle attachment click | ||
| }, | ||
| onTrailingIconClick = { | ||
| // Handle trailing icon click | ||
| }, | ||
| trailingIcon = TarkaIcons.Regular.Send20, | ||
| state = UpLoading(50), | ||
| showLeadingIcon = true, | ||
| ) | ||
|
|
||
| // Example Attachment Uploader of Video | ||
| TUIAttachmentUpload( | ||
| modifier = Modifier | ||
| .fillMaxWidth() |
There was a problem hiding this comment.
Here as well its better if we add some space between two components
| Column(Modifier.fillMaxSize(). padding(8.dp), horizontalAlignment = Alignment.CenterHorizontally) { | ||
| Text(text = "TUIFloatingNavBar", style = TUITheme.typography.heading3) | ||
| // Example Floating navigation bar with custom tab items | ||
| TUIFloatingNavBar( |
There was a problem hiding this comment.
We have remove this TUIFloatingNavBar component form TakaUIKit
| Column(Modifier.fillMaxSize(). padding(8.dp), horizontalAlignment = Alignment.CenterHorizontally) { | ||
| Text(text = "TUIFloatingTab", style = TUITheme.typography.heading3) | ||
| // Example Floating tab with default appearance | ||
| TUIFloatingTab( |
| fun TUIMenuItemComposable() { | ||
| Column(Modifier.fillMaxSize(). padding(8.dp), horizontalAlignment = Alignment.CenterHorizontally) { | ||
| Text(text = "TUIMenuItem", style = TUITheme.typography.heading3) | ||
| TUIMenuItem( |
There was a problem hiding this comment.
This component is not available in TUIKit can you please check
| Column(Modifier.fillMaxSize(). padding(8.dp), horizontalAlignment = Alignment.CenterHorizontally) { | ||
| Text(text = "TUIMultiLevelSelectorHeader", style = TUITheme.typography.heading3) | ||
| // When the header is selected. | ||
| TUIMultiLevelSelectorHeader( |
There was a problem hiding this comment.
TUIMultiLevelSelectorHeader is not available in tarkaUi kit
NandagopalR
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##3 feature: kitchen sink app
Screen_recording_20240229_093855.webm