Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added port list functionality and increased range of baud rates available via serial_posix.go #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Dec 14, 2015

  1. Added GetPortsList method to all implementations, shamelessly lifted

    from the gobug.st/serial package and subject to the conditions of its
    license (which has been reproduced in source as per terms of said
    license)
    
    Updated serial_posix to support full list of termios baud rates (as per
    existing serial_linux implementation).
    
    Moved posixTimeoutValues method from top level serial.go to new
    serial_x.go source file, as only required for linux and posix
    implementations.
    Cormac Cannon committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    deb5733 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2015

  1. Changes as per PR feedback, namely:

    Added ListPorts method in serial.go that delegates to platform
    implementation called listPorts. Associated godoc explicitly states that posix
    implementation is just a convenient heuristic. Renamed platform-specific
    implementations in serial_posix.go and serial_windows.go from
    GetPortsList to listPorts for consistency.
    
    Reverted baud-rate additions in serial_posix.go. May be included a
    future PR.
    
    Corrected erroneous exporting of function in serial_windows.go
    
    Tidied up posix implementation of listPorts.
    
    Externalised portname filter definition to posix_<platform>.go
    Cormac Cannon committed Dec 17, 2015
    Configuration menu
    Copy the full SHA
    fad2c08 View commit details
    Browse the repository at this point in the history