Merge pull request #1 from madflojo/negative_poolsize

Handle Negative Pool Sizes
tarmac-project · Jan 4, 2024 · 61c4d41 · 61c4d41
2 parents a81a408 + 7f73fb8
commit 61c4d41
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/engine/wasm.go b/engine/wasm.go
@@ -101,9 +101,9 @@ func (s *Server) LoadModule(cfg ModuleConfig) error {
 	m.ctx, m.cancel = context.WithCancel(context.Background())
 
 	// Set Pool Size
-	m.poolSize = uint64(cfg.PoolSize)
-	if cfg.PoolSize == 0 {
-		m.poolSize = uint64(DefaultPoolSize)
+	m.poolSize = uint64(DefaultPoolSize)
+	if cfg.PoolSize > 0 {
+		m.poolSize = uint64(cfg.PoolSize)
 	}
 
 	// Read the WASM module file

diff --git a/engine/wasm_test.go b/engine/wasm_test.go
@@ -61,6 +61,17 @@ func TestWASMModuleCreation(t *testing.T) {
 		},
 	})
 
+	// Negative Pool Size
+	mc = append(mc, ModuleCase{
+		Name: "Negative Pool Size",
+		Pass: true,
+		ModuleConf: ModuleConfig{
+			Name:     "A Module",
+			PoolSize: -1,
+			Filepath: "../testdata/hello-go/hello.wasm",
+		},
+	})
+
 	// No File
 	mc = append(mc, ModuleCase{
 		Name: "No File",