Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/lint: convert lints to pre-commit & Ruff #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Borda
Copy link

@Borda Borda commented Apr 30, 2024

simplify the linting with easier-to-read pre-commit, which can also be installed as a bot (which may commit linting fixes to open PRs)
With his pre-commit, we also explicitly set used versions, so there are sudden issues due to the recently released new linter version
Moreover, wrapping several linters and formatted to Ruff rule, which is a much faster tool:

  • flake8 -> rule 'E', 'F', 'W'
  • isort -> rule 'I'
  • pyupgrade -> rule 'UP'
  • bandit -> rule 'S'
  • bugbear -> rule 'B'
  • comprehensions -> rule 'C4'

cc: @tartley @hugovk

@Borda
Copy link
Author

Borda commented Aug 14, 2024

@tartley @hugovk

mind have a look, when you have time 🦩

@hugovk
Copy link
Contributor

hugovk commented Aug 14, 2024

I don't have merge permissions here, and the pre-commit CI failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants