test(notifier): add test for BasicGenerator (#34)

apps/server/internal/pkg/notifier/account.go

@@ -34,7 +34,6 @@ func NewEmailAccountNotifier(opts OptsEmailAccNotifier) *EmailAccountNotifier {
 }
 
 func (n *EmailAccountNotifier) VerifyEmail(username string, email string) error {
-
 	confirmLink, _, err := n.lg.VerifyLink()
 	if err != nil {
 		return errors.Wrap(err, "verify email")

apps/server/internal/pkg/notifier/account_test.go

@@ -19,11 +19,11 @@ type testGenerator struct {
 }
 
 func (t *testGenerator) VerifyLink() (link string, id uuid.UUID, err error) {
-	return fmt.Sprintf("%s/verify/id=%s", t.cfg.HostDomain, uuid.Nil), uuid.Nil, nil
+	return fmt.Sprintf("%s/verify?id=%s", t.cfg.HostDomain, uuid.Nil), uuid.Nil, nil
 }
 
 func (t *testGenerator) UnsubLink() (link string, id uuid.UUID, err error) {
-	return fmt.Sprintf("%s/unsub/id=%s", t.cfg.HostDomain, uuid.Nil), uuid.Nil, nil
+	return fmt.Sprintf("%s/unsub?id=%s", t.cfg.HostDomain, uuid.Nil), uuid.Nil, nil
 }
 
 type args struct {

apps/server/internal/pkg/notifier/generator.go

@@ -31,7 +31,7 @@ func (b *BasicGenerator) VerifyLink() (string, uuid.UUID, error) {
 	_, err = sb.WriteString("/verify?id=")
 	err = multierr.Append(err, err)
 
-	_, err = sb.WriteString(b.HostDomain)
+	_, err = sb.WriteString(confirmID.String())
 	err = multierr.Append(err, err)
 
 	return sb.String(), confirmID, err
@@ -51,7 +51,7 @@ func (b *BasicGenerator) UnsubLink() (string, uuid.UUID, error) {
 	_, err = sb.WriteString("/unsub?id=")
 	err = multierr.Append(err, err)
 
-	_, err = sb.WriteString(b.HostDomain)
+	_, err = sb.WriteString(unsubID.String())
 	err = multierr.Append(err, err)
 
 	return sb.String(), unsubID, err

apps/server/internal/pkg/notifier/generator_test.go

@@ -0,0 +1,46 @@
+package notifier
+
+import (
+	"fmt"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"regexp"
+	"strconv"
+	"testing"
+)
+
+func TestBasicGenerator_VerifyLink(t *testing.T) {
+	regex, err := regexp.Compile(".*/verify\\?id=[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}")
+	require.NoError(t, err)
+	for i := range 10 {
+		t.Run(strconv.Itoa(i), func(t *testing.T) {
+			b := &BasicGenerator{
+				HostDomain: fmt.Sprintf("%d.com", i),
+			}
+			link, _, err := b.VerifyLink()
+			assert.NoError(t, err)
+
+			t.Log(link)
+			match := regex.Match([]byte(link))
+			assert.True(t, match)
+		})
+	}
+}
+
+func TestBasicGenerator_UnsubLink(t *testing.T) {
+	regex, err := regexp.Compile(".*/unsub\\?id=[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}")
+	require.NoError(t, err)
+	for i := range 10 {
+		t.Run(strconv.Itoa(i), func(t *testing.T) {
+			b := &BasicGenerator{
+				HostDomain: fmt.Sprintf("%d.com", i),
+			}
+			link, _, err := b.UnsubLink()
+			assert.NoError(t, err)
+
+			t.Log(link)
+			match := regex.Match([]byte(link))
+			assert.True(t, match)
+		})
+	}
+}