Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth service #32

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Refactor auth service #32

merged 5 commits into from
Sep 12, 2024

Conversation

ripls56
Copy link
Member

@ripls56 ripls56 commented Sep 12, 2024

Main goal was to incapsulate notification send logic to more simple api

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 15.75758% with 139 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libs/queue/mock_Queue.go 0.00% 76 Missing ⚠️
apps/server/internal/pkg/notifier/account.go 25.00% 30 Missing ⚠️
libs/queue/mock_ConsumeFn.go 0.00% 22 Missing ⚠️
apps/server/internal/pkg/notifier/email.go 72.72% 3 Missing and 3 partials ⚠️
apps/server/internal/service/auth/service.go 0.00% 5 Missing ⚠️
Flag Coverage Δ
./apps/notification 0.00% <ø> (ø)
./apps/server 6.72% <38.80%> (+0.71%) ⬆️
./libs/queue 0.00% <0.00%> (?)
./libs/template 63.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/server/internal/config/config.go 50.00% <ø> (ø)
apps/server/internal/service/auth/service.go 0.00% <0.00%> (ø)
apps/server/internal/pkg/notifier/email.go 72.72% <72.72%> (ø)
libs/queue/mock_ConsumeFn.go 0.00% <0.00%> (ø)
apps/server/internal/pkg/notifier/account.go 25.00% <25.00%> (ø)
libs/queue/mock_Queue.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@ripls56 ripls56 merged commit e7f2908 into dev Sep 12, 2024
10 checks passed
@ripls56 ripls56 deleted the refactor/auth-service branch September 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant