Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job-scheduler): use delayed job data when template data is not present #3010

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Jan 14, 2025

Why

Enter your explanation here.

  1. Why is this change necessary? Since version v5.31.0 template data is saved in job scheduler record, and since v5.34.8 this same data is used for saving the next delayed job that is produced by a job scheduler. If someone migrates to v5.34.8 or a greater version, without recreating their job scheduler, next delayed jobs won't get data information.

How

  1. How did you implement this? Pass delayed job data when updating a job scheduler, if no data is saved as template, reuse data from previous delayed job

Additional Notes (Optional)

Any extra info here.
fixes #3009

@roggervalf roggervalf merged commit 95edb40 into master Jan 14, 2025
11 checks passed
@roggervalf roggervalf deleted the fix-job-scheduler-data branch January 14, 2025 01:33
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
## [5.34.10](v5.34.9...v5.34.10) (2025-01-14)

### Bug Fixes

* **job-scheduler:** use delayed job data when template data is not present ([#3010](#3010)) fixes [#3009](#3009) ([95edb40](95edb40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Job data gets removed for repeatable job after first run
1 participant