NUXT ❤️ PWA #77
NUXT ❤️ PWA #77
Conversation
site/_apps/nuxt-hn.txt
Outdated
| interactive-em: '2.8s' | ||
| interactive-faster-3g: '2.4s' | ||
| lighthouse-link: https://www.webpagetest.org/lighthouse.php?test=170620_PG_a2a9feaf4ace07a61b2c6c2a171b1c79&run=1 | ||
| wpt-em-link: https://www.webpagetest.org/result/170620_AM_f5e1ae2f305c1d81b44cfe0c9c930e35 |
There was a problem hiding this comment.
Looks like the interactive times are do not quite match the report, and there was an issue with the main thread settling in the EM_3G test.
Started some new tests here:
em - https://www.webpagetest.org/result/170620_2Y_5f5fdbaae7d479adf52986a98fc8a720/
faster - https://www.webpagetest.org/result/170620_WP_e35e74fdc07b32752e1b642cf8e159f9/
Will take a look after they complete.
There was a problem hiding this comment.
EM_3G report finished. Main thread didn't settle down, but we did get a value for First Interactive at 4.5s.
https://www.webpagetest.org/result/170620_2Y_5f5fdbaae7d479adf52986a98fc8a720/
https://www.webpagetest.org/lighthouse.php?test=170620_2Y_5f5fdbaae7d479adf52986a98fc8a720&run=1
There was a problem hiding this comment.
Faster 3G finished as well, with a similar story. First interactive at 3.9s.
https://www.webpagetest.org/result/170620_84_60a994930d1424f8bdb69b6fb98b7391/
https://www.webpagetest.org/lighthouse.php?test=170620_84_60a994930d1424f8bdb69b6fb98b7391&run=1
There was a problem hiding this comment.
That's strange with webpagetest results. Things like https redirect should be passed too but failing here! Would you give some points why that mainThread problem happens? Isn't it active because of prefetching js files?
There was a problem hiding this comment.
The http->https problem is a known issue unfortunately, every implementation is impacted :(
See here for details: GoogleChrome/lighthouse#2363
|
@addyosmani We've seen a few entries get caught in this stage, where a Consistently Interactive time cannot be recorded. I believe we should consider adding them. |
|
Aside from updating the interactive numbers, this PR looks good to me. @kristoferbaxter agreed. I think we can update all the entries once they all record consistently interactive numbers (mentioned #60) |
|
@kristoferbaxter @housseindjirdeh Thanks for your time & quick response :)
Is there anything needed from our side before merge? |
There was a problem hiding this comment.
This looks good to me 👍
This is such an awesome app - @pi0 @alexchopin @atinux you folks did a outstanding job so thank you for submitting this 🎉
|
Appreciate it if you would like to take a look @addyosmani as well but will be merging this in because of urgency (VueConf tomorrow) |
Hi! Here is our latest hnpwa implementation with Nuxt.js framework built on top of Vue. Originally ported from vue-hackernews-2 so original design credits back to them :)
Appendix: it would be so awesome if it could be merged just before VueConf (tomorrow), me & nuxt team can be responsible for any immediate changes that required before merge.