Add Example using Lit #2178
Closed
Add Example using Lit #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
force-pushed
the
cb-add-lit
branch
from
694e49c
to
e18c9af
Compare
julienw
reviewed
May 23, 2023
Comment on lines
+26
to
+29
| get isEditing () { | ||
| const state = store.getState() | ||
| return this.todo.id === state.editingTodo | ||
| } |
There was a problem hiding this comment.
I think it would be better to connect the TodoList component, and pass isEditing as a boolean property.
This way we wouldn't rerender all the items (see requestUpdate below) when the state of just one item changes, or even the state of any other thing that's not related to these items.
Note that I know very little about Lit so I may be off here.
|
closing in favor of #2196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lit is a great framework for building apps based on web components. This patch adds a TodoMVC example using this framework + Redux for data management. If desired I can remove the redux part.