Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean JS files for case-insensitive file systems #1057

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

heyanlong
Copy link
Contributor

@heyanlong heyanlong commented Nov 29, 2023

When installing in case-insensitive operating systems, such as WSL2 and macOS, the case of the JS language file will be considered to be one file, and composer will cause an error.

@sampoyigi
Copy link
Member

Can you add some description of what issue this is solving?

@ObjectBoxPC
Copy link

(Note: I am new to this codebase so my understanding of the situation may be incomplete.)

In this directory there appear to be "duplicate" locale files, some that use capital letters for the country code (for example "en-AU") and some that use lowercase letters ("en-au"). Files whose names differ only in letter case can cause problems on case-insensitive filenames. Besides that, they are confusing because it's not clear which one is actually being used for the given locale.

These appear to have been introduced in commit 415499e .

@sampoyigi sampoyigi merged commit f45c55c into tastyigniter:3.x Feb 5, 2024
13 checks passed
@sampoyigi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants