Skip to content

Commit

Permalink
Update node to current LTS
Browse files Browse the repository at this point in the history
- Updated node version in github actions
- Updated node and npm version in readme
- Updated node docker image
- Pinned node and npm version in plugin and api-server package.json
- Updated node and npm version in plugin and api-server package.json
  • Loading branch information
duggalsu committed Oct 24, 2023
1 parent 5f4f2f0 commit c54490b
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-pr-review-both-browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: "Setup Node version"
uses: actions/setup-node@v3
with:
node-version: 18.18.2
node-version: 20.8.1

- name: Get commit SHA
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions browser-extension/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

Requirements :

- npm : v9.8.1
- nodejs : v18.18.2
- npm : v10.1.0
- nodejs : v20.8.1

When you run `docker-compose up`, ensure to have a `development.env` file with the following variables in the `api-server` directory.

Expand Down
2 changes: 1 addition & 1 deletion browser-extension/api-server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.18.2-alpine3.18@sha256:0fe7402d11d8c85474c6ec6f9c9c8048cd0549c95535832b7f0735a4b47690a5
FROM node:20.8.1-alpine3.18@sha256:002b6ee25b63b81dc4e47c9378ffe20915c3fa0e98e834c46584438468b1d0b5
ENV NODE_ENV production
WORKDIR /app

Expand Down
4 changes: 2 additions & 2 deletions browser-extension/api-server/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions browser-extension/api-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"uuid": "8.3.2"
},
"engines": {
"node": ">=18.18.2",
"npm": ">=9.8.1"
"node": "20.8.1",
"npm": "10.1.0"
},
"devDependencies": {
"husky": "8.0.3"
Expand Down
4 changes: 2 additions & 2 deletions browser-extension/plugin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions browser-extension/plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
},
"engines": {
"browsers": "> 0.25%",
"node": ">=18.18.2",
"npm": ">=9.8.1"
"node": "20.8.1",
"npm": "10.1.0"
},
"lint-staged": {
"*.(js|jsx)": [
Expand Down

0 comments on commit c54490b

Please sign in to comment.