Fix uli-website dependabot issues [WiP] #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reformatted package.json - Ran npm audit fix - Resolved multiple peer dependency issues - Applied dependency pinning
- Can not update styled-components to latest. It breaks grommet - Made misc changes to markdown file Styling for markdown pages is completely broken because gatsby-plugin-mdx's latest version is a major rewrite and it makes styling very different from how we do it. Will need more work before we can merge
|
Closing this PR. Will open package-specific PRs for incremental updates with fixes for breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See - https://stackoverflow.com/questions/64936044/fix-the-upstream-dependency-conflict-installing-npm-packages
I basically ended up upgrading all packages to the latest version.
npm auditstill shows issues and suggests downgrades as a force fix which introduces previously existing vulnerabilities and we keep going in loops upgrading/downgrading if we go down that path.The only resolution for any currently flagged vulnerabilities is to wait for affected packages to be fixed upstream.
Since multiple packages had major version upgrades, the website needs to be tested (hence the WiP).
Edit: This fixes https://github.com/tattle-made/security/issues/25