Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github actions to build browser extension for pull requests #373

Merged
merged 52 commits into from
Sep 20, 2023

Conversation

aatmanvaidya
Copy link
Collaborator

@aatmanvaidya aatmanvaidya commented Sep 19, 2023

Describe the PR
This PR resolves #347.
This PR has the github action code to build the browser extension when a pull request is made to the main branch of tattle-made/Uli.
Once a user makes the PR, a comment (bot) will pop up having 2 links. One which contains the build folder for firefox and the other for chrome.

Steps to test the PR

  1. Make a pull request to the main branch of tattle-made/Uli

@dennyabrain apologies for the large number of commits, but every time to test a change in the action, I had to push the changes and make a PR to test them out.

@ghost
Copy link

ghost commented Sep 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@dennyabrain
Copy link
Contributor

dennyabrain commented Sep 19, 2023

No worries about the multiple commits. Unfortunately there's no other way to test github actions, so this was expected :) i'll squash them into one commit so not a problem.

Lets see if we can combine the two actions into 1. I think we could build the firefox and chrome version in the same action. So the build action could look something like

cd browser-extension/plugin
ls
pwd
npm install
npm run build:firefox
mv dist/ extension-firefox/
npm run build
mv dist/ extension-chrome/

Then configure the upload-artifact action :

- uses: actions/upload-artifact@v3
  with:
    name: my-artifact
    path: |
      dist-firefox/
      dist-chrome/

I think this would create one artifact zip files with two folders for each extension.

@aatmanvaidya
Copy link
Collaborator Author

I think the github actions are failing because we haven't given write access for GITHUB_TOKEN. We will have to do that in tattle-made/Uli

@dennyabrain dennyabrain self-requested a review September 20, 2023 07:11
@dennyabrain dennyabrain merged commit 31d7597 into tattle-made:main Sep 20, 2023
2 of 3 checks passed
@aatmanvaidya aatmanvaidya deleted the actions branch September 20, 2023 09:21
duggalsu pushed a commit that referenced this pull request Oct 24, 2023
Builds the extension for firefox and chrome and adds a link to them under the PR comments section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automations to help expedite PR reviews and QA
2 participants