refactor: changing permission for url in manifest #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatmanvaidya
added
the
level:ticket
|
closing this for now, as will make a new PR against the development branch and not the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we add permissions to the
manifest.jsonfile.@duggalsu pointed out that Manifest v3 does not recommend adding URL's to
permissions, instead they suggest we add URL's tohost_permissionshost_permissions- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissionsI have made this change for
manifest.jsonand tested out in chromium based browsers. I have not made this change for firefox as it still uses manifest v2@dennyabrain you can review this at your time of comfort and then merge it