-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to extract language from video #408
Added support to extract language from video #408
Conversation
merge dev to main
hi @plon-Susk7 - I am facing an error when I run the test from inside the docker container. ResourceWarning: Enable tracemalloc to get the object allocation traceback
.Error extracting audio: ffmpeg error (see stderr output for detail)
E
======================================================================
ERROR: test_english_detection_video (core.operators.test_detect_lang_of_media.Test.test_english_detection_video)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/app/core/operators/test_detect_lang_of_media.py", line 28, in test_english_detection_video
lang = detect_lang_of_media.run(audio_file_path,'video')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/app/core/operators/detect_lang_of_media.py", line 236, in run
extract_audio_from_video(audio_file["path"])
File "/usr/app/core/operators/detect_lang_of_media.py", line 136, in extract_audio_from_video
.run(quiet=True, overwrite_output=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/app/venv/lib/python3.11/site-packages/ffmpeg/_run.py", line 325, in run
raise Error('ffmpeg', out, err)
ffmpeg._run.Error: ffmpeg error (see stderr output for detail) am I doing something wrong? also there are other some small things I feel we should do
Let me know if I can be of help in any of the above! |
I'll make the necessary changes soon. |
hi, did you accidentally close the PR? or any specific reason to do so? |
Sorry Aatman this was accidental. I'll open it again once changes are made. |
We are converting the mp4 file to speech file. So isn't removing videos same as removing speech here? Are we supposed to physically remove the file from disk? |
yes we have to physically remove the file from disk |
|
stats after profiling |
@plon-Susk7 thank you so much for your work and effort, things look good, merging the PR! |
Solved issue #319