Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALL-5690 Fix AddressTransaction type in non-breaking way #1088

Merged
merged 2 commits into from
Apr 10, 2024
Merged

ALL-5690 Fix AddressTransaction type in non-breaking way #1088

merged 2 commits into from
Apr 10, 2024

Conversation

hehe100596
Copy link
Collaborator

Fixed types for getTransactions method in address module in a non-breaking way. More proper fix will be introduced in later major version.

@hehe100596 hehe100596 force-pushed the hotfix/ALL-5690-fix-addr-txs-types branch from 528d7fc to 063f260 Compare April 9, 2024 15:39
@hehe100596 hehe100596 force-pushed the hotfix/ALL-5690-fix-addr-txs-types branch from 063f260 to e344186 Compare April 9, 2024 15:40
filipkastovsky
filipkastovsky approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@filipkastovsky filipkastovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the types 🙌.

@hehe100596 hehe100596 merged commit 5d44b67 into master Apr 10, 2024
8 checks passed
@hehe100596 hehe100596 deleted the hotfix/ALL-5690-fix-addr-txs-types branch April 10, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipkastovsky filipkastovsky filipkastovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hehe100596 @filipkastovsky