Simplify parse_page() in extractor code
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the level two language title node is used in these functions, other nodes are ignored and the code could be simplified with the `WikiNode.find_child()` method.
also enable deprecation warnings
|
I see some changes to the import order in the /de files. Do you use some kind of auto-sort on the imports? I'd be happy to follow the prefered order. |
|
I used the |
|
Hi @empiriker, I left some comments to your German extractor pull request earlier today, please check them out. |
|
I think all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the level two language title node is used in these functions, other nodes are ignored and the code could be simplified with the
WikiNode.find_child()method.