refactor!: no_std & no static msvcrt & remove download plugin (#26)

.cargo/config.toml

@@ -1,5 +1,2 @@
 [build]
 target = "i686-pc-windows-msvc"
-
-[target.i686-pc-windows-msvc]
-rustflags = ["-C", "target-feature=+crt-static"]

.changes/config.json

@@ -44,16 +44,6 @@
         }
       ]
     },
-    "nsis_download": {
-      "path": "./crates/nsis-download",
-      "manager": "rust",
-      "assets": [
-        {
-          "path": "target/i686-pc-windows-msvc/release/${ pkg.pkg }.dll",
-          "name": "${ pkg.pkg }.dll"
-        }
-      ]
-    },
     "nsis_process": {
       "path": "./crates/nsis-process",
       "manager": "rust",

.changes/no_std.md

@@ -0,0 +1,7 @@
+---
+"nsis_tauri_utils": "minor"
+"nsis_semvercompare": "minor"
+"nsis_process": "minor"
+---
+
+Reduce the DLL size by using `no_std` and without static msvcrt.

.github/workflows/audit.yml

@@ -27,8 +27,7 @@ jobs:
   audit:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: rust audit
-        uses: actions-rs/audit-check@v1
+      - uses: actions/checkout@v4
+      - uses: rustsec/audit-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/change-status-on-pr.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: windows-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: covector status

.github/workflows/clippy-fmt.yml

@@ -18,33 +18,17 @@ jobs:
   clippy:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
-      - name: install stable
-        uses: actions-rs/toolchain@v1
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          profile: minimal
-          toolchain: stable
-          override: true
           components: clippy
+      - run: cargo clippy --release --all-targets --all-features -- -D warnings
 
-      - uses: actions-rs/cargo@v1
-        with:
-          command: clippy
-          args: --all-targets --all-features -- -D warnings
-
-  fmt:
+  rustfmt:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
-      - name: install stable
-        uses: actions-rs/toolchain@v1
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
         with:
-          profile: minimal
-          toolchain: stable
-          override: true
           components: rustfmt
-
-      - uses: actions-rs/cargo@v1
-        with:
-          command: fmt
-          args: --all -- --check
+      - run: cargo fmt --all -- --check

.github/workflows/covector-version-or-publish.yml

@@ -19,16 +19,11 @@ jobs:
       successfulPublish: ${{ steps.covector.outputs.successfulPublish }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
-      - name: Setup node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-          check-latest: true
-          registry-url: 'https://registry.npmjs.org'
+      - uses: actions/setup-node@v4
 
       - name: git config
         run: |

.github/workflows/test.yml

@@ -22,15 +22,6 @@ jobs:
     runs-on: windows-latest
 
     steps:
-      - uses: actions/checkout@v2
-
-      - name: install stable
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-
-      - uses: actions-rs/cargo@v1
-        with:
-          command: test
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - run: cargo test --features test

Cargo.toml

@@ -8,7 +8,7 @@ edition = "2021"
 license = "MIT or Apache-2.0"
 
 [workspace.dependencies]
-pluginapi = { path = "./crates/pluginapi" }
+nsis-plugin-api = { path = "./crates/nsis-plugin-api" }
 
 [workspace.dependencies.windows-sys]
 version = "0.52.0"
@@ -24,8 +24,8 @@ features = [
 ]
 
 [profile.release]
-codegen-units = 1
-lto = true
-opt-level = "s"
-panic = "abort"
-strip = "symbols"
+panic = "abort"   # Strip expensive panic clean-up logic
+codegen-units = 1 # Compile crates one after another so the compiler can optimize better
+lto = true        # Enables link time optimizations
+opt-level = "s"   # Optimize for binary size
+strip = true      # Remove debug symbols

README.md

@@ -2,13 +2,12 @@
 
 A collection of NSIS plugins written in rust.
 
-|  Plugin  |  Description  |
-|---|---|
-|  [nsis-download](./crates/nsis-download/)  |  Download a file from an URL to a path  |
-|  [nsis-process](./crates/nsis-process/)  |  Find and Kill processes  |
-|  [nsis-semvercompare](./crates/nsis-semvercompare/)  |  Compare two semantic versions  |
-|  [nsis-tauri-utils](./crates/nsis-tauri-utils/)  |  A collection of all the above plugins into a single DLL for smaller size  |
+| Plugin                                             | Description                                                              |
+| -------------------------------------------------- | ------------------------------------------------------------------------ |
+| [nsis-process](./crates/nsis-process/)             | Find and Kill processes                                                  |
+| [nsis-semvercompare](./crates/nsis-semvercompare/) | Compare two semantic versions                                            |
+| [nsis-tauri-utils](./crates/nsis-tauri-utils/)     | A collection of all the above plugins into a single DLL for smaller size |
 
 ## License
 
-Apache-2.0/MIT
+Apache-2.0/MIT