refactor!: no_std & no static msvcrt & remove download plugin

.cargo/config.toml

@@ -1,5 +1,2 @@
 [build]
 target = "i686-pc-windows-msvc"
-
-[target.i686-pc-windows-msvc]
-rustflags = ["-C", "target-feature=+crt-static"]

.changes/config.json

@@ -44,16 +44,6 @@
         }
       ]
     },
-    "nsis_download": {
-      "path": "./crates/nsis-download",
-      "manager": "rust",
-      "assets": [
-        {
-          "path": "target/i686-pc-windows-msvc/release/${ pkg.pkg }.dll",
-          "name": "${ pkg.pkg }.dll"
-        }
-      ]
-    },
     "nsis_process": {
       "path": "./crates/nsis-process",
       "manager": "rust",

.changes/no_std.md

@@ -0,0 +1,7 @@
+---
+"nsis_tauri_utils": "minor"
+"nsis_semvercompare": "minor"
+"nsis_process": "minor"
+---
+
+Reduce the DLL size by using `no_std` and without static msvcrt.

Cargo.toml

@@ -8,7 +8,7 @@ edition = "2021"
 license = "MIT or Apache-2.0"
 
 [workspace.dependencies]
-pluginapi = { path = "./crates/pluginapi" }
+nsis-plugin-api = { path = "./crates/nsis-plugin-api" }
 
 [workspace.dependencies.windows-sys]
 version = "0.52.0"
@@ -24,8 +24,8 @@ features = [
 ]
 
 [profile.release]
-codegen-units = 1
-lto = true
-opt-level = "s"
-panic = "abort"
-strip = "symbols"
+panic = "abort"   # Strip expensive panic clean-up logic
+codegen-units = 1 # Compile crates one after another so the compiler can optimize better
+lto = true        # Enables link to optimizations
+opt-level = "s"   # Optimize for binary size
+strip = true      # Remove debug symbols

README.md

@@ -2,13 +2,12 @@
 
 A collection of NSIS plugins written in rust.
 
-|  Plugin  |  Description  |
-|---|---|
-|  [nsis-download](./crates/nsis-download/)  |  Download a file from an URL to a path  |
-|  [nsis-process](./crates/nsis-process/)  |  Find and Kill processes  |
-|  [nsis-semvercompare](./crates/nsis-semvercompare/)  |  Compare two semantic versions  |
-|  [nsis-tauri-utils](./crates/nsis-tauri-utils/)  |  A collection of all the above plugins into a single DLL for smaller size  |
+| Plugin                                             | Description                                                              |
+| -------------------------------------------------- | ------------------------------------------------------------------------ |
+| [nsis-process](./crates/nsis-process/)             | Find and Kill processes                                                  |
+| [nsis-semvercompare](./crates/nsis-semvercompare/) | Compare two semantic versions                                            |
+| [nsis-tauri-utils](./crates/nsis-tauri-utils/)     | A collection of all the above plugins into a single DLL for smaller size |
 
 ## License
 
-Apache-2.0/MIT
+Apache-2.0/MIT

crates/nsis-fn/Cargo.toml

@@ -0,0 +1,13 @@
+[package]
+name = "nsis-fn"
+version = "0.0.0"
+edition = "2021"
+license = "MIT OR Apache-2.0"
+
+[lib]
+proc-macro = true
+
+[dependencies]
+proc-macro2 = "1"
+quote = "1"
+syn = { version = "2", features = ["full"] }

crates/nsis-fn/src/lib.rs

@@ -0,0 +1,48 @@
+use proc_macro::TokenStream;
+use proc_macro2::Span;
+use quote::quote;
+use syn::{parse::Parse, parse_macro_input, Ident, ItemFn};
+
+struct NsisFn {
+    func: ItemFn,
+}
+
+impl Parse for NsisFn {
+    fn parse(input: syn::parse::ParseStream) -> syn::Result<Self> {
+        let func: ItemFn = input.parse()?;
+        Ok(Self { func })
+    }
+}
+
+#[proc_macro_attribute]
+pub fn nsis_fn(_attr: TokenStream, tokens: TokenStream) -> TokenStream {
+    let tokens = parse_macro_input!(tokens as NsisFn);
+    let NsisFn { func } = tokens;
+
+    let ident = func.sig.ident;
+    let block = func.block;
+    let attrs = func.attrs;
+
+    let new_ident = Ident::new(&format!("__{}", ident.to_string()), Span::call_site());
+
+    quote! {
+        #[inline(always)]
+        pub unsafe fn #new_ident() -> Result<(), ::nsis_plugin_api::Error> #block
+
+        #(#attrs)*
+        #[no_mangle]
+        #[allow(non_standard_style)]
+        pub unsafe extern "C" fn #ident(
+            hwnd_parent: ::windows_sys::Win32::Foundation::HWND,
+            string_size: core::ffi::c_int,
+            variables: *mut ::nsis_plugin_api::wchar_t,
+            stacktop: *mut *mut ::nsis_plugin_api::stack_t,
+        ) {
+            ::nsis_plugin_api::exdll_init(string_size, variables, stacktop);
+            if let Err(e) = #new_ident() {
+                e.push_err();
+            }
+        }
+    }
+    .into()
+}

crates/pluginapi/Cargo.toml → crates/nsis-plugin-api/Cargo.toml

@@ -1,8 +1,9 @@
 [package]
-name = "pluginapi"
+name = "nsis-plugin-api"
 version = "0.0.0"
 edition = "2021"
 license = "MIT OR Apache-2.0"
 
 [dependencies]
 windows-sys = { workspace = true }
+nsis-fn = { path = "../nsis-fn" }