Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add support to universal links #752

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 28, 2023 11:28
@lucasfernog
Copy link
Member Author

I tried to make the event generic so it can be reused on #422. We should finally agree on an event name thinking about Tauri v2.

So with this change my idea is that #422 is changed to use the OpenEvent and add the File variant (and maybe having both OpenEvent::Url and OpenEvent::File taking a Vec instead of a single value).

src/event.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 8f361f0 into dev Jul 3, 2023
@lucasfernog lucasfernog deleted the feat/ios-universal-links branch July 3, 2023 11:48
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants