Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split min/max size constraints #759

Merged
merged 17 commits into from
Jul 11, 2023
Merged

feat: split min/max size constraints #759

merged 17 commits into from
Jul 11, 2023

Conversation

amrbashir
Copy link
Member

closes #138

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir requested a review from a team as a code owner July 5, 2023 17:05
@amrbashir
Copy link
Member Author

macOS testers needed here

@pewsheen
Copy link
Contributor

pewsheen commented Jul 6, 2023

macOS testers needed here

It works well on macOS 🎉

@amrbashir amrbashir force-pushed the feat/split-min-max-size-constraints branch from 6692902 to f4f5af0 Compare July 7, 2023 01:04
@amrbashir
Copy link
Member Author

A few cleanup using macros from rust-windowing/winit#2148, I've already tested Windows and Linux but would love to get second eyes and approvals here:

@pewsheen
Copy link
Contributor

pewsheen commented Jul 7, 2023

A few cleanup using macros from rust-windowing/winit#2148, I've already tested Windows and Linux but would love to get second eyes and approvals here:

macOS is fine 👍

@FabianLars
Copy link
Member

So far tested on fedora38+gnome, wsl (ubuntu2204), and windows. Any specific DEs or distros you want me to test?

@amrbashir
Copy link
Member Author

amrbashir commented Jul 10, 2023 •
edited
Loading

Not really, these are enough, thanks

@amrbashir
Copy link
Member Author

Alright, this should be read for approval.

FabianLars
FabianLars approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(only skimmed over the macros part since i'm not really into that stuff, but the rest looks solid to me)

@amrbashir
Copy link
Member Author

alright, I will ping @wusyong to take a look before I merge

@amrbashir amrbashir merged commit ea14c6b into dev Jul 11, 2023
9 checks passed
@amrbashir amrbashir deleted the feat/split-min-max-size-constraints branch July 11, 2023 13:55
@amrbashir amrbashir mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Constrain window width, but not window height.
4 participants
@amrbashir @pewsheen @FabianLars @wusyong