Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): allow setting window class name, closes #769 #770

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

geraudloup
Copy link
Contributor

@geraudloup geraudloup commented Jul 25, 2023

allow to customize the window class name instead of current value hard coded "Window Class"

Currently, on Windows, all windows created by Tao have the same class Window Class, it would be neet to allow for customization of the Windows' window class name. One use case: some windows custom hotkey managers leverage window class names to select windows...

Waiting for merge in upstream project winit (pass all 55 checks) : rust-windowing/winit#2978
(closing mirrored issue rust-windowing/winit#2977)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

allow to customize it instead of current value hard coded "Window Class"
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, could you also add a changefile in .changes directory?

src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
geraudloup and others added 3 commits July 27, 2023 19:21
allow to customize it instead of current value hard coded "Window Class"
@geraudloup
Copy link
Contributor Author

Thanks for your contribution, could you also add a changefile in .changes directory?

Yes ! I added one (following the exemple of windows-ltr.md) and tested and accepted your suggested changes (I also updated my PR on winit with your improvements) !

@amrbashir amrbashir changed the title On Windows, set name of Window Class, closes #769 feat(windows): allow setting window class name, closes #769 Jul 28, 2023
@amrbashir amrbashir merged commit 75eb0c1 into tauri-apps:dev Jul 28, 2023
9 checks passed
@amrbashir
Copy link
Member

@wusyong should this API be ported to the v0.16 branch or wait until tauri v2?

@amrbashir
Copy link
Member

cherry picked into v0.16 in ae664f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants