Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade to ndk 0.9 and fix thread-safety interactions #956

Merged
merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. chore(deps): Upgrade to ndk 0.9 and fix thread-safety interactions

    Most changes were copied over from my `wry` PR at
    tauri-apps/wry#1296.  Most notably a
    `&ThreadLooper` is now passed to `wry::android_setup()` because we
    have one, and it gives important safety guarantees when it comes to
    registering callbacks on this looper, without (unnecessarily!) requiring
    `Send`.  A thread-local requirement already exists for the `JNIEnv` that
    is passed around anyway.
    
    Also note that certain workarounds and illogical inverted passes
    around `key_code()` handling are no longer needed, as the `ndk` crate
    now passes an `enum` with the raw `i32` around so that the `.into()`
    conversion for `i32` (the correct type) now becomes lossless.
    MarijnS95 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f396851 View commit details
    Browse the repository at this point in the history