fix(build): avoid copying resource onto itself (#9710)

* fix(build): avoid copying resource onto itself closes #9666 * canonicalize once --------- Co-authored-by: Lucas Nogueira <[email protected]>
tauri-apps · May 28, 2024 · 19b696b · 19b696b
1 parent ccc3ea7
commit 19b696b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/.changes/build-resource-target-same-src.md b/.changes/build-resource-target-same-src.md
@@ -0,0 +1,6 @@
+---
+"tauri-build": "patch:bug"
+---
+
+Avoid copying resources if the target path is the same as source.
+
diff --git a/core/tauri-build/src/lib.rs b/core/tauri-build/src/lib.rs
@@ -93,10 +93,18 @@ fn copy_binaries(
 
 /// Copies resources to a path.
 fn copy_resources(resources: ResourcePaths<'_>, path: &Path) -> Result<()> {
+  let path = path.canonicalize()?;
   for resource in resources.iter() {
     let resource = resource?;
+
     println!("cargo:rerun-if-changed={}", resource.path().display());
-    copy_file(resource.path(), path.join(resource.target()))?;
+
+    // avoid copying the resource if target is the same as source
+    let src = resource.path().canonicalize()?;
+    let target = path.join(resource.target());
+    if src != target {
+      copy_file(src, target)?;
+    }
   }
   Ok(())
 }