Skip to content

Commit

Permalink
refactor: rename TAURI_SIGNTOOL_PATH -> `TAURI_WINDOWS_SIGNTOOL_PAT…
Browse files Browse the repository at this point in the history
…H` (#10595)

immediately after merging #10588 I noticed that the variable name might be a bit ambigious and could cause confusion on other pl atforms other than Windows
  • Loading branch information
amrbashir authored Aug 14, 2024
1 parent 78e22be commit 39bf0a1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .changes/cli-signtool-path.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"tauri-bundler": patch:feat
---

`TAURI_SIGNTOOL_PATH` environment variable for specifying the path to signtool.exe.
`TAURI_WINDOWS_SIGNTOOL_PATH` environment variable for specifying the path to signtool.exe.
2 changes: 1 addition & 1 deletion tooling/bundler/src/bundle/windows/sign.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ fn signtool() -> Option<PathBuf> {
static SIGN_TOOL: OnceLock<crate::Result<PathBuf>> = OnceLock::new();
SIGN_TOOL
.get_or_init(|| {
if let Some(signtool) = std::env::var_os("TAURI_SIGNTOOL_PATH") {
if let Some(signtool) = std::env::var_os("TAURI_WINDOWS_SIGNTOOL_PATH") {
return Ok(PathBuf::from(signtool));
}

Expand Down
1 change: 1 addition & 0 deletions tooling/cli/ENVIRONMENT_VARIABLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ These environment variables are inputs to the CLI which may have an equivalent C
- `TAURI_SIGNING_PRIVATE_KEY_PASSWORD` — The signing private key password, see `TAURI_SIGNING_PRIVATE_KEY`.
- `TAURI_SIGNING_RPM_KEY` — The private GPG key used to sign the RPM bundle, exported to its ASCII-armored format.
- `TAURI_SIGNING_RPM_KEY_PASSPHRASE` — The GPG key passphrase for `TAURI_SIGNING_RPM_KEY`, if needed.
- `TAURI_WINDOWS_SIGNTOOL_PATH` — Specify a path to `signtool.exe` used for code signing the application on Windows.
- `APPLE_CERTIFICATE` — Base64 encoded of the `.p12` certificate for code signing. To get this value, run `openssl base64 -in MyCertificate.p12 -out MyCertificate-base64.txt`.
- `APPLE_CERTIFICATE_PASSWORD` — The password you used to export the certificate.
- `APPLE_ID` — The Apple ID used to notarize the application. If this environment variable is provided, `APPLE_PASSWORD` and `APPLE_TEAM_ID` must also be set. Alternatively, `APPLE_API_KEY` and `APPLE_API_ISSUER` can be used to authenticate.
Expand Down

0 comments on commit 39bf0a1

Please sign in to comment.